Add FXIOS-6238 - ShareTo Extension Changes To Light or Dark Theme When iOS Appearance Is Changed

[tisumi99]

📜 Tickets

Jira ticket
Github issue

💡 Description

ShareTo extension updated so that it now responds to the light/dark mode appearance setting in iOS. LightTheme() or DarkTheme() from Firefox theme is applied to the corresponding appearance settting.

InstructionsView

• Added import Common to get access to Firefox themes.
• Added @Environment(\.colorScheme) var colorScheme property to track changes to iOS appearance setting.
• Added useSystemLightDarkMode property to enable or disable view responding to iOS appearance setting. Property is set to false by default to allow for backwards compatibility to other parts of the app that also use this view.
• Moved code for the main view into mainView property to allow for re-use.
• Added branching to body property so toolbar background is modified if iOS16 or greater.
• Added helper functions in InstructionsView extension. Helper functions will apply the appropriate theme colors if useSystemLightDarkMode is true, else the view property colors as set when the view was created are applied.

DevicePickerViewController

• Moved tabTitleLabel property and code for setting the nav bar title into setNavBarTitle() so it is re-usable.
• Added setNavBarAppearance() to configure the nav bar backgound colors.
• Added subclass SendToDevicePickerViewController: DevicePickerViewController. Subclass has delegate traitCollectionDidChange() that responds to iOS appearance changes.

SendToDeviceHelper

• Moved InstructionsView() call into getInstructionsView() so subclass can override.
• Moved DevicePickerViewController() call into getDevicePickerViewController() so subclass can override.
• Added subclass SendToExtensionHelper: SendToDeviceHelper to pass useSystemLightDarkMode flag to InstructionsView and call subclass SendToDevicePickerViewController instead of DevicePickerViewController

SendToDevice

• Updated code to use subclass SendToExtensionHelper instead of SendToDeviceHelper and pass useSystemLightDarkMode: true flag.

ShareViewController

• Changed currentTheme() to use traitCollection.userInterfaceStyle to set the appropriate theme in response to changes in appearance setting.
• Added delegate traitCollectionDidChange() that responds to iOS appearance changes.

📝 Checklist

You have to check all boxes before merging

• Filled in the above information (tickets numbers and description of your work)
• Updated the PR name to follow our PR naming guidelines
• Wrote unit tests and/or ensured the tests suite is passing
• When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
• If needed, I updated documentation / comments for complex code and public methods
• If needed, added a backport comment (example @Mergifyio backport release/v120)

[tisumi99]

Before - ShareTo Doesn't Change Theme

Screen.Recording.2024-05-16.at.12.00.38.PM.mp4

After - ShareTo Updates Theme

Screen.Recording.2024-05-16.at.12.06.11.PM.mp4

[github-actions]

This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions!