Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FXIOS-9145 Move WindowUUID into Common #20292

Merged
merged 6 commits into from
May 21, 2024

Conversation

mattreaganmozilla
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

Moves WindowUUID out of Client and into Common / BrowserKit.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@mobiletest-ci-bot
Copy link

Warnings
⚠️ Variable 'crossCircleFill' in Medium is out of alphabetical order.
⚠️ Variable 'cross' in Medium is out of alphabetical order.
Messages
📖 Project coverage: 32.4%
📖 Edited 96 files
📖 Created 0 files

Client.app: Coverage: 30.95

File Coverage
SiriSettingsViewController.swift 11.54% ⚠️
SearchBarSettingsViewController.swift 33.33% ⚠️
RemoteTabsPanelAction.swift 100.0%
MicrosurveyPromptState.swift 86.96%
PrivateModeAction.swift 0.0% ⚠️
GeneralBrowserAction.swift 0.0% ⚠️
BackForwardListAnimator.swift 1.98% ⚠️
NewTabContentSettingsViewController.swift 7.45% ⚠️
FakespotAction.swift 0.0% ⚠️
BookmarksCoordinator.swift 79.17%
ReaderPanel.swift 45.2% ⚠️
TabTrayAction.swift 100.0%
TabsSettingsViewControler.swift 16.13% ⚠️
Authenticator.swift 0.0% ⚠️
OnboardingViewControllerState.swift 0.0% ⚠️
TabsPanelState.swift 58.62%
JumpBackInDataAdaptor.swift 83.27%
ToastType.swift 0.0% ⚠️
ActiveScreenAction.swift 100.0%
SearchSettingsState.swift 0.0% ⚠️
MicrosurveyPromptAction.swift 100.0%
MicrosurveyPromptMiddleware.swift 47.5% ⚠️
BrowserViewControllerState.swift 0.0% ⚠️
AppState.swift 89.66%
PhotonActionSheetAnimator.swift 0.0% ⚠️
TopSitesRowCountSettingsController.swift 0.0% ⚠️
TabEventHandler.swift 83.49%
SearchTermGroupsUtility.swift 51.79%
TabPanelAction.swift 100.0%
PasswordManagerCoordinator.swift 90.0%
TabPeekAction.swift 0.0% ⚠️
DownloadQueue.swift 50.0% ⚠️
TabTrayState.swift 50.0% ⚠️
CreditCardBottomSheetViewModel.swift 76.29%
OpenWithSettingsViewController.swift 4.29% ⚠️
Tab.swift 39.8% ⚠️
CreditCardSettingsViewModel.swift 27.69% ⚠️
DownloadsPanel.swift 38.93% ⚠️
TabLocationView.swift 41.67% ⚠️
ReadabilityService.swift 0.0% ⚠️
OpenWithSetting.swift 0.0% ⚠️
AppLaunchUtil.swift 0.0% ⚠️
SiteTableViewController.swift 56.91%
JumpBackInViewModel.swift 37.53% ⚠️
ReaderModeStyleViewModel.swift 83.93%
ClipboardBarDisplayHandler.swift 0.0% ⚠️
TabPeekState.swift 0.0% ⚠️
OnboardingViewModelProtocol.swift 100.0%
RemoteTabsCoordinator.swift 85.0%
LibraryViewController+LibraryPanelDelegate.swift 81.25%
RecentlyClosedTabsPanel.swift 6.52% ⚠️
TopSitesSettingsViewController.swift 10.14% ⚠️
LibraryPanelHelper.swift 77.78%
SearchSettingsTableViewController.swift 1.72% ⚠️
ToolbarMiddleware.swift 11.76% ⚠️
NavigationToolbarContainerModel.swift 0.0% ⚠️
CreditCardTableViewModel.swift 2.44% ⚠️
ThemeSettingsAction.swift 100.0%
ActiveScreenState.swift 75.53%

libStorage.a: Coverage: 59.7

File Coverage
BrowserDB.swift 83.95%

Generated by 🚫 Danger Swift against 50d2d29

Copy link
Contributor

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks!

@mattreaganmozilla mattreaganmozilla merged commit c6fda0a into mozilla-mobile:main May 21, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants