-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor FXIOS-9145 Move WindowUUID into Common #20292
Merged
mattreaganmozilla
merged 6 commits into
mozilla-mobile:main
from
mattreaganmozilla:mr/9145
May 21, 2024
Merged
Refactor FXIOS-9145 Move WindowUUID into Common #20292
mattreaganmozilla
merged 6 commits into
mozilla-mobile:main
from
mattreaganmozilla:mr/9145
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattreaganmozilla
force-pushed
the
mr/9145
branch
from
May 16, 2024 22:48
4d0f494
to
50d2d29
Compare
Client.app: Coverage: 30.95
libStorage.a: Coverage: 59.7
Generated by 🚫 Danger Swift against 50d2d29 |
cyndichin
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! thanks!
OrlaM
approved these changes
May 21, 2024
mattreaganmozilla
merged commit May 21, 2024
c6fda0a
into
mozilla-mobile:main
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Moves WindowUUID out of Client and into Common / BrowserKit.
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)