Bugfix FXIOS-9089 Update TabCell title after pushing Home in toolbar #20293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataports
requested review from
adudenamedruby and
OrlaM
and removed request for
adudenamedruby
adudenamedruby
approved these changes
May 21, 2024
OrlaM
approved these changes
May 21, 2024
dataports
force-pushed
the
sa/fxios-9089_after-pressing-home-tab-title-uses-previous-title
branch
from
f5c38a1
to
8bd77fb
Compare
dataports
force-pushed
the
sa/fxios-9089_after-pressing-home-tab-title-uses-previous-title
branch
from
8bd77fb
to
109f54b
Compare
Client.app: Coverage: 31.18
Generated by 🚫 Danger Swift against d4572cc |
dataports
deleted the
sa/fxios-9089_after-pressing-home-tab-title-uses-previous-title
branch
|
@Mergifyio backport release/v126 |
✅ Backports have been created
|
Merged
6 tasks
|
@dataports This also needs a backport for 127 since it landed in main for 128. I'll do the backport now. |
|
@Mergifyio backport release/v127 |
✅ Backports have been created
|
Merged
6 tasks
DonalMe
pushed a commit
that referenced
this pull request
May 23, 2024
…20293) (#20396) --------- Co-authored-by: Sophie Amin <samin@KPQ47DG99L.local> Co-authored-by: Sophie Amin <samin@KPQ47DG99L.lan> (cherry picked from commit 6c3d60a) # Conflicts: # firefox-ios/firefox-ios-tests/Tests/ClientTests/Microsurvey/MicrosurveyViewControllerTests.swift Co-authored-by: Sophie <5545720+dataports@users.noreply.github.com>
DonalMe
pushed a commit
that referenced
this pull request
May 24, 2024
…20293) (#20378) --------- Co-authored-by: Sophie Amin <samin@KPQ47DG99L.local> Co-authored-by: Sophie Amin <samin@KPQ47DG99L.lan> (cherry picked from commit 6c3d60a) # Conflicts: # firefox-ios/firefox-ios-tests/Tests/ClientTests/Microsurvey/MicrosurveyViewControllerTests.swift Co-authored-by: Sophie <5545720+dataports@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Replaced logic for displayTitle so that if we are on a Homepage we immediately return the Homepage title and skip the rest of the logic.
Video After Changes
Simulator.Screen.Recording.-.iPhone.15.-.2024-05-16.at.16.49.35.mp4
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)