Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FXIOS-9170 - [Fonts] BackForwardTableViewCell #20325

Conversation

DanielDervishi
Copy link
Collaborator

馃摐 Tickets

Jira ticket
Github issue

馃挕 Description

Update Fonts related to BackForwardTableViewCell to use FXFontStyles

NOTE:

There are two potential changes to satisfy this ticket.

@cwzilla, would any of the following potential changes be acceptable?

Before:

Before

Potential Change #1:

Caption - After

Potential Change #2:

Body - After

馃摑 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@DanielDervishi DanielDervishi requested a review from a team as a code owner May 17, 2024 19:16
@cyndichin cyndichin requested review from cyndichin and cwzilla and removed request for PARAIPAN9 May 17, 2024 19:23
Copy link
Contributor

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielDervishi code looks great from my side!

@cwzilla can you confirm the changes from the screenshots and that caption1 style is to be used in this case. thanks!

@mobiletest-ci-bot
Copy link

Warnings
鈿狅笍 Variable 'crossCircleFill' in Medium is out of alphabetical order.
鈿狅笍 Variable 'cross' in Medium is out of alphabetical order.
Messages
馃摉 Project coverage: 32.54%
馃摉 Edited 1 files
馃摉 Created 0 files

Client.app: Coverage: 31.21

File Coverage
BackForwardTableViewCell.swift 0.0% 鈿狅笍

Generated by 馃毇 Danger Swift against 298ef91

@cwzilla
Copy link

cwzilla commented May 22, 2024

@DanielDervishi @cyndichin potential change #1 looks good to me. Thanks!

@cyndichin cyndichin merged commit f43e19e into mozilla-mobile:main May 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants