Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FXIOS-9163 - Updated Fonts On Tabs to FXFontStyles #20329

Merged
merged 1 commit into from
May 23, 2024

Conversation

tisumi99
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Updated TabCell, TopTabCell, and TabPrintPageRenderer to use FXFontsStyle instead of DefaultDynamicFontHelper or UIFont. This eliminates the need to specify font sizes in the view controllers.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@tisumi99 tisumi99 requested a review from a team as a code owner May 18, 2024 18:42
@tisumi99 tisumi99 requested a review from nbhasin2 May 18, 2024 18:42
@tisumi99
Copy link
Contributor Author

Originally font weight was set to .semibold, FXFontStyles only has .medium weight for same font size.
Screenshot 2024-05-18 at 11 43 22 AM

Screenshot 2024-05-18 at 11 45 35 AM

Screenshots from webpage printed to PDF.
Screenshot 2024-05-18 at 11 46 16 AM

@cyndichin cyndichin requested review from cyndichin and removed request for nbhasin2 May 20, 2024 13:35
Copy link
Contributor

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @tisumi99! As always, thank you for the before and after screenshots, they help tremendously!! tagging @cwzilla for design review.

@mobiletest-ci-bot
Copy link

Warnings
⚠️ Variable 'crossCircleFill' in Medium is out of alphabetical order.
⚠️ Variable 'cross' in Medium is out of alphabetical order.
Messages
📖 Project coverage: 32.54%
📖 Edited 3 files
📖 Created 0 files

Client.app: Coverage: 31.2

File Coverage
TabPrintPageRenderer.swift 0.0% ⚠️
TopTabCell.swift 0.0% ⚠️
TabCell.swift 71.96%

Generated by 🚫 Danger Swift against 0c8c2fe

@cwzilla
Copy link

cwzilla commented May 22, 2024

LGTM!!

@cyndichin cyndichin merged commit 2699f50 into mozilla-mobile:main May 23, 2024
10 checks passed
@tisumi99 tisumi99 deleted the 20306TabFXFontStyles branch May 23, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants