Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FXIOS-9168 - Updated Fonts On PhotonActionSheetView to FXFontStyles #20331

Merged
merged 1 commit into from
May 22, 2024
Merged

Refactor FXIOS-9168 - Updated Fonts On PhotonActionSheetView to FXFontStyles #20331

merged 1 commit into from
May 22, 2024

Conversation

tisumi99
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Updated PhotonActionSheetView to use FXFontsStyle instead of DefaultDynamicFontHelper or UIFont. This eliminates the need to specify font sizes in the view controllers.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@tisumi99 tisumi99 requested a review from a team as a code owner May 19, 2024 18:53
@tisumi99
Copy link
Contributor Author

Screenshot 2024-05-19 at 11 54 04 AM

Screenshot 2024-05-19 at 11 54 32 AM

Screenshot 2024-05-19 at 11 54 51 AM

Screenshot 2024-05-19 at 11 55 09 AM

Screenshot 2024-05-19 at 11 55 33 AM

Screenshot 2024-05-19 at 11 55 49 AM

@cyndichin cyndichin requested review from cyndichin and cwzilla and removed request for adudenamedruby May 20, 2024 13:34
cyndichin
cyndichin approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisumi99 Thank you for these updates! Code looks good, will tag @cwzilla to confirm slight font changes.

@mobiletest-ci-bot
Copy link

Warnings
⚠️ Variable 'crossCircleFill' in Medium is out of alphabetical order.
⚠️ Variable 'cross' in Medium is out of alphabetical order.
Messages
📖 Project coverage: 32.54%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 31.2

File Coverage
PhotonActionSheetView.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against ce9a45c

cwzilla
cwzilla approved these changes May 22, 2024
View reviewed changes
Copy link

@cwzilla cwzilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you so much!

@adudenamedruby adudenamedruby merged commit d75cea1 into mozilla-mobile:main May 22, 2024
9 of 10 checks passed
@tisumi99 tisumi99 deleted the 20316PhotoActionSheetFXFontStyles branch May 23, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyndichin cyndichin cyndichin approved these changes

@cwzilla cwzilla cwzilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tisumi99 @mobiletest-ci-bot @cyndichin @cwzilla @adudenamedruby