Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the "not actively monitored" banner on Android as well #13010

Merged

Conversation

diox
Copy link
Member

@diox diox commented May 16, 2024

Fixes mozilla/addons#2207

The change should be straightforward enough to be verified by the unit test alone, and the issue explains the context a bit more, but if you want to check locally:

  1. Visit /en-US/android/ with a Firefox for Android User Agent (on Desktop, Firefox responsive mode with some custom UA should do the trick)
  2. Follow the link to a non-recommended add-on
  3. Notice the "not actively monitored" grey banner is present

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (7a2da9d) to head (4a041cd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13010      +/-   ##
==========================================
- Coverage   98.28%   98.28%   -0.01%     
==========================================
  Files         267      267              
  Lines       10509    10508       -1     
  Branches     3178     3177       -1     
==========================================
- Hits        10329    10328       -1     
  Misses        167      167              
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@diox diox requested review from a team, chrstinalin and KevinMind and removed request for a team and chrstinalin May 16, 2024 09:55
@KevinMind
Copy link
Contributor

Verified:

image

I used the UA: Mozilla/5.0 (Android 14; Mobile; rv:126.0) Gecko/126.0 Firefox/126.0

Copy link
Contributor

@KevinMind KevinMind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@diox diox merged commit d9ac75f into mozilla:master May 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants