Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateInput: fix 修复在popover模式下选择年份月份时popover会关闭的问题 #1401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sun79
Copy link

@Sun79 Sun79 commented Aug 13, 2019

选择年份月份后click事件会冒泡到外面导致popover被错误关闭
修复https://github.com/museui/muse-ui/issues/1395 https://github.com/museui/muse-ui/issues/1327

The DateInput will close after selecting the year or month in popover mode.
@codecov-io
Copy link

codecov-io commented Aug 13, 2019

Codecov Report

Merging #1401 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1401      +/-   ##
==========================================
- Coverage   30.18%   30.09%   -0.09%     
==========================================
  Files         220      220              
  Lines        3578     3585       +7     
  Branches      749      751       +2     
==========================================
- Hits         1080     1079       -1     
- Misses       1880     1885       +5     
- Partials      618      621       +3
Impacted Files Coverage Δ
src/Select/mixins/selection.js 0% <ø> (ø) ⬆️
src/BottomSheet/BottomSheet.js 100% <ø> (ø) ⬆️
src/Tooltip/Tooltip.js 0% <0%> (ø) ⬆️
src/DateInput/DateInput.js 10.52% <0%> (-1.24%) ⬇️
src/utils/translate.js 42.85% <0%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74f78df...f927975. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants