Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typeof instead of instanceof to check for object #485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

b-chamagne
Copy link

Hello,
I had an issue with some of the toolbar button (bold/italic) that were not working.
I think it had to do with the way I loadData(), but could not figure out what's wrong exactly.

Here's the issue from devtool (it is a style.font) :
Screenshot from 2021-06-22 10-22-25

This would make the helper.equals returns truthy instead of falsy which skip the creation of a new style (thus reuse an existing one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants