WV-2978 E2E Test Fixes #5203
Merged
WV-2978 E2E Test Fixes #5203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix adds a new url parameter
e2ethat can be added to urls, specifically to be used in e2e tests. The url parameter prevents the notification modal from opening on page load, which was causing inconsistency in tests passing due to variable time to load the modal onscreen.How To Test
git checkout wv-2978-e2e-test-fixesnpm cinpm run watchapp.js, change line 203 fromnumberOutagesUnseen,tonumberOutagesUnseen: notifications.number,temporarily to force the notifications modal to open on page load.npx playwright test animation/animation-test.spec.jsand verify that the tests pass.