Update dashboard.js typo #3485
Open
Update dashboard.js typo #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 2, 2023 01:24
Super Constructor: When calling the super(message) constructor, it's better to pass a more descriptive message, like "CumulusApiClientError: " + message, so that when you catch this error, you'll immediately know what type of error it is without having to inspect the class name.
…ot provided the implementation for this function. Ensure that it handles errors correctly. In the getPrivateKey() method, KMS.decryptBase64String(fetchedKey) is used, but it appears the result isn't awaited. If decryptBase64String is asynchronous, you need to use await. Encryption & Decryption: decrypt is imported and used, but you have not provided the implementation for this function. Ensure that it handles errors correctly. In the getPrivateKey() method, KMS.decryptBase64String(fetchedKey) is used, but it appears the result isn't awaited. If decryptBase64String is asynchronous, you need to use await.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Summary of changes
Addresses CUMULUS-XX: Develop amazing new feature
Changes
PR Checklist