Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/es-phase-1 #3648

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

feature/es-phase-1 #3648

wants to merge 9 commits into from

Conversation

jennyhliu
Copy link
Contributor

Summary: Summary of changes

Addresses CUMULUS-XX: Develop amazing new feature

Changes

  • Detailed list or prose of changes
  • ...

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests

…sic queries (#3637)

* CUMULUS-3692:Granule list endpoint for basic postgres query
jennyhliu and others added 8 commits May 10, 2024 16:39
…er by field value (#3656)

* CUMULUS-3692:Granule list endpoint for basic postgres query

* refactor

* refactor

* typing

* add changelog entry

* skip search_after

* skip searchafter unit tests

* add granule list test

* rename

* refactor

* build query parameters

* update comment

* add field-mapping

* update jsdoc

* use type over interface,add log

* update test description

* build term/terms

* buildDbQueryParameters

* add unit test no terms search

* add doc

* rename

* add unit test

* add fields test

* add more unit tests

* support error.Error search

* fix lint

* rename functions

* ignore files

* add convert query unit tests

* add all types

* add unit test for fieldmapping types fix timestamp

* update timestamp test

* add multiple term field test

* ignore execution in granule list record
…se psql (#3659)

* first commit on new branch

* CHANGELOG change

* small fix

* PR feedback

* adding jsdoc + fixing spelling/grammar
* first committ

* CHANGELOG change

* fixing sortQueryMethod

* simplifying code

* PR feedback

* merge conflicts + improving code

* small jsdoc fix

* PR feedback

* PR feedback

* PR feedback

* fixing test

* PR feedback

* PR feedback
@@ -101,19 +101,12 @@ function _createNewGranuleDateValue() {
* @returns {Promise<Object>} the promise of express response object
*/
async function list(req, res) {
log.trace(`list query ${JSON.stringify(req.query)}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jkovarik mentioned that we generally use log.info, and using log.trace is a change to how we're logging so should be discussed with the team.
see convo https://github.com/nasa/cumulus/pull/3681/files#diff-c8cc016ab2b04a286a25bb2d230e35fe63392b371a4178296f58f6388936d72c
Is there a reason to use log.trace instead of log.info?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants