-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmony 1616 - Replacing npm with pnpm #554
Open
indiejames
wants to merge
35
commits into
main
Choose a base branch
from
harmony-1616-3
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies to package.json files
clean up pacakge.json and Docker files
buildkit install to run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-1616
Description
This is a massive change that replaces our use of
npm
withpnpm
. This is mainly to take advantage ofpnpm
's support for monorepos and faster dependency installation. I have tested building images and using them locally and in the sandbox. There is still plenty of other things that need testing, like running Harmony in a Box from scratch and things related to CICD, but I wanted to get this out there so you guys can get a sense of what is coming.Feel free to push back on whether or not this change is a good idea. I think it simplifies some things (like the Docker builds), but it is a big change.
Local Test Steps
pnpm
by running the following in the harmony repo:pnpm
to install dependencies (will take a while the first time)HARMONY-1616-3
ofharmony-ci-cd
reopThen run set your images in your .env in harmony-ci-cd to match $VERSION and run
./bin/deploy
as usual.PR Acceptance Checklist