Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced traceback capture for SAS failures #441

Merged
merged 5 commits into from
May 21, 2024

Conversation

collinss-jpl
Copy link
Collaborator

Description

  • This branch enhances the error reporting from SAS failures by utilizing a regular expression to capture a full traceback stack from the log, rather than just the last 20 lines.

Affected Issues

Testing

  • Unit test for a failing SAS condition has been updated to ensure the full traceback (which is longer than 20 lines in this test) is now provided in the error message that would be reported to an SDS end user.

@collinss-jpl collinss-jpl self-assigned this May 16, 2024
@collinss-jpl collinss-jpl force-pushed the 423_enhanced_traceback_capture_for_SAS branch from 9bba6ee to 720bb11 Compare May 16, 2024 19:03
Copy link
Collaborator

@JimHofman JimHofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@collinss-jpl collinss-jpl merged commit 080bc3f into main May 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Feature]: Enhanced Traceback capture for failed SAS subprocess
2 participants