Update Electron to 21 + Node to 16 (#1550)

.github/workflows/ci.yml

@@ -19,10 +19,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - name: Use Node.js 19
+      - name: Use Node.js 20
         uses: actions/setup-node@v2
         with:
-          node-version: 19
+          node-version: 20
           cache: 'npm'
           cache-dependency-path: |
             npm-shrinkwrap.json
@@ -37,10 +37,10 @@ jobs:
     runs-on: windows-latest # Doesn't work on headless ubuntu, and is slow on mac
     steps:
       - uses: actions/checkout@v2
-      - name: Use Node.js 19
+      - name: Use Node.js 20
         uses: actions/setup-node@v2
         with:
-          node-version: 19
+          node-version: 20
           cache: 'npm'
           cache-dependency-path: |
             npm-shrinkwrap.json
@@ -59,8 +59,8 @@ jobs:
     strategy:
       matrix:
         node-version:
-          - '19'
-          - '12' # the oldest we require in package.json -> engines.node, to check we run on this minimum
+          - '20'
+          - '16' # the oldest we require in package.json -> engines.node, to check we run on this minimum
         platform: [ubuntu-latest, macos-latest, windows-latest]
     runs-on: ${{ matrix.platform }}
     steps:

.github/workflows/publish.yml

@@ -10,7 +10,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1 # Setup .npmrc file to publish to npm
         with:
-          node-version: '19' # Align the version of Node here with ci.yml.
+          node-version: '20' # Align the version of Node here with ci.yml.
           registry-url: 'https://registry.npmjs.org'
       - run: npm ci --no-fund # Will also (via `prepare` hook): 1. install ./app, 2. build
       - run: npm run test:playwright
@@ -23,7 +23,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1 # Setup .npmrc file to publish to npm
         with:
-          node-version: '19' # Align the version of Node here with ci.yml.
+          node-version: '20' # Align the version of Node here with ci.yml.
           registry-url: 'https://registry.npmjs.org'
       - run: npm ci --no-fund # Will also (via `prepare` hook): 1. install ./app, 2. build
       - run: npm run test:noplaywright

HACKING.md

@@ -127,8 +127,10 @@ When a new major [Electron release](https://github.com/electron/electron/release
    (also via the [Releases page](https://github.com/electron/electron/releases) and [the blog](https://www.electronjs.org/blog/), the content is different),
    grepping our codebase for every changed API.
    - If called for by the breaking changes, perform the necessary API changes
-3. Bump `src/constants.ts` / `DEFAULT_ELECTRON_VERSION` & `DEFAULT_CHROME_VERSION`
-   and `app / package.json / devDeps / electron`
+3. Bump
+   - `src/constants.ts` / `DEFAULT_ELECTRON_VERSION` & `DEFAULT_CHROME_VERSION`
+   - `package.json / devDeps / electron`
+   - `app / package.json / devDeps / electron`
 4. On Windows, macOS, Linux, test for regression and crashes:
    1. With `npm test` and `npm run test:manual`
    2. With extra manual testing

README.md

@@ -31,8 +31,8 @@ Whatsapp Web ([HN thread](https://news.ycombinator.com/item?id=10930718)). Nativ
 
 Install Nativefier globally with `npm install -g nativefier` . Requirements:
 
-- macOS 10.10+ / Windows / Linux
-- [Node.js](https://nodejs.org/) ≥ 12.9 and npm ≥ 6.9
+- macOS 10.13+ / Windows / Linux
+- [Node.js](https://nodejs.org/) ≥ 16.9 and npm ≥ 7.10
 
 Optional dependencies: