-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable User Brew theme selection #3321
base: master
Are you sure you want to change the base?
Enable User Brew theme selection #3321
Conversation
This has been implemented three different ways to allow for comparison and discussion - /api/css/:id : This returns the style frontmatter of the referenced document as a text/css document. /api/theme/:id : This returns an object with the reference'd object's theme and style frontmatter. /api/csstheme/:id : This returns the stylye frontmatter of the referenced document as a text/css document and adds the theme as an @import ( if not using the legacy renderer )
This adds a comment/field ( depending on endpoint ) that reports the name of the Brew being used as a theming source.
This consolidates the style/theme endpoint to a singular method, adds interpretation of static themes, and allow parent theme recursion. I am not 100% sure this will order styles correctly.
This updates the theme picker to include brews tagged as themes owned by the user. Some supporting functions were updated. User themes are loaded on /edit and added to the request.
Test theme: https://homebrewery.naturalcrit.com/share/qr7i-TXHV8yf |
A theme from a brew with If you could in this PR, make sure legacy renderer brews are ignored completely, that would be nice. |
…mebrewery into brew_themes_user_selection
Can't provide example right now as the whole system seems to be failing. |
This adds the User Brew themes, where applicible, to the /new path. This adds a semi-graceful failure to the metadata panel when a Brew Theme is declared as used but is not present. More gracefully handles loading with themes not present.
For User/Brew Themes, display the first author instead of Brew/V3 in the first column.
Add 5e-Cleric's suggestsions to acvoid the title overflowing over the preview.
What do we need to bring this one to the end? |
I still want to give this one a deep review for code quality but if the functionality is working it should be mostly ready. This will be next on the stack when I get #3261 merged which should be soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall nice changes, will further test, but this looks good
This adds the UI elements to the metadata selector for users to select brews tagged as
theme
orTheme
as a brew's theme.It also swaps in use of the CSS endpoints ( with small changes ) from #3303