scanner/ffmpeg: change to use ffprobe

[vs49688]

ffprobe can output JSON and should be shipped anywhere ffmpeg is.

Handling JSON is much nicer than unstructured text.

Note that I removed some tests that no longer make sense after the change, e.g. the TBPM, FBPM, and multi-line comment tests.

[deluan]

Thanks for this, I do agree that ffprobe is a better metadata extractor, and actually I originally implemented it with ffprobe (that's why the config option is called ProbeCommand) but unfortunately you missed one important feature of ffmpeg vs ffprobe: Batching! Please read this: #1294 (comment)

[vs49688]

Ah, I completely missed that thread. How about linking with libav{format,codec} and pulling out the data directly?

Could also get rid of the need for an external compressor that way too...

[deluan]

Ah, I completely missed that thread. How about linking with libav{format,codec} and pulling out the data directly?

Linking to C libraries make the project very complex to maintain (see explanation here: #1124 (comment)). SQLite3 and (specially) TagLib already give me enough headaches... Check the docker image I have to maintain to be able to build Navidrome statically

Could also get rid of the need for an external compressor that way too...

This goes against the architecture decision of allowing external transcoders to be used to support formats unknown to Navidrome (see #351 (comment))

Can I ask you what is your motivation to get rid of ffmpeg? Is it causing any issues?

[vs49688]

Ah, I completely missed that thread. How about linking with libav{format,codec} and pulling out the data directly?

Linking to C libraries make the project very complex to maintain (see explanation here: #1124 (comment)). SQLite3 and (specially) TagLib already give me enough headaches... Check the docker image I have to maintain to be able to build Navidrome statically

Could also get rid of the need for an external compressor that way too...

This goes against the architecture decision of allowing external transcoders to be used to support formats unknown to Navidrome (see #351 (comment))

Fair enough, I wasn't aware that was intended.

Can I ask you what is your motivation to get rid of ffmpeg? Is it causing any issues?

No, not at all. I wanted to start off with something relatively simple to get familiar with the codebase, before I tackle #489.

[deluan]

No, not at all. I wanted to start off with something relatively simple to get familiar with the codebase, before I tackle #489.

Ah, I see. Your code looks good to me but unfortunately, for the reasons above, I'll not be able to merge it, ok? Closing this now, but feel free to reach out (preferable in Discord) to discuss #489

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.