ReplayGain support + audio normalization (web player) #1988

kgarner7 · 2022-11-14T07:20:50Z

resolve #1850, resolve #233, and part of #1036

This PR seeks to add extraction of ReplayGain tags, the ability to get this data via the native API, and audio normalization in the web player.

The web player is unchanged, I have just elected to use the Web Audio API to wrap around the <audio> element. I'm not sure if the gainNode with values > 1 is problematic or not yet (maybe they need to be normalized to 1?).

I'd be happy to have some feedback/additional testing (or if someone has a different player, now might be a good time to switch).

deluan · 2022-11-22T04:17:56Z

Nice! I'll take a look and give you feedback on this as soon as I can. Thanks!

deluan · 2022-12-07T00:13:33Z

Hey @kgarner7 , does this take into consideration transcoding? I think we need to make ffmpeg add the RG tags in the output, so other players would receive the tags.

kgarner7 · 2022-12-07T00:43:17Z

I'm not entirely sure how transcoding would play a role. Does that change the replaygain properties of the track (e.g., if I started with flac and converted it to ogg, would those values change)? The tags come from the original file (and are stored in the db).

deluan · 2022-12-07T01:01:04Z

I may be wrong, but I think we just have to reuse the tags from the original file in the transcoded one. I think ffmpeg handles this. We have to dig a bit more. We can always have a following PR to handle that.

kgarner7 · 2022-12-07T01:45:00Z

Ah, if the concern is whether ffmpeg will expose those same tags to the new file, I believe the answer is yes (when I transcoded my library to Play:Sub, which does replaygain, I could see gain info).

- extract ReplayGain tags from files, expose via native api - use metadata to normalize audio in web player

github-actions · 2022-12-07T02:09:46Z

Download the artifacts for this pull request:

rsammelson · 2022-12-07T02:50:11Z

I play my music transcoded from FLAC to Opus, and the gain was working correctly in the web player too.

deluan · 2022-12-07T02:59:31Z

@rsammelson My questioning is about other clients, the Subsonic clients. Will they benefit from this? Base on @kgarner7 , seems that this works as well

kgarner7 · 2022-12-07T03:10:41Z

Ahhh,I understand now. I don't think so. The reason why Play:Sub worked was because it read the tags from file. It isn't exposed on subsonic routes (I guess I could modify childFromMediaFile?), but I'm not sure that is used...

deluan · 2023-01-17T00:28:04Z

Ahhh,I understand now. I don't think so. The reason why Play:Sub worked was because it read the tags from file. It isn't exposed on subsonic routes (I guess I could modify childFromMediaFile?), but I'm not sure that is used...

Yes, that's how Subsonic clients handle ReplayGain. We just need to be sure that whatever RG tags are in the files, they remain intact after transcoding. My understanding is that is what currently happens (based on your test with play:Sub), right? To be sure, you could also download a track with transcoding ON and check if ffmpeg -i downloaded_track.mp3 has the same tags as the original.

kgarner7 · 2023-01-17T00:35:02Z

I downloaded a transcoded track, and I can confirm that the replaygain attributes are still there (I also manually transcoded with ffmpeg for same results).

deluan

This looks great! Just need to test it locally and see how the UX feels.

deluan · 2023-01-17T00:30:41Z

db/migration/20221113142454_add_replaygain_metadata.go

+alter table media_file add 
+	album_gain real;
+alter table media_file add 
+	album_peak real;
+alter table media_file add 
+	track_gain real;
+alter table media_file add 
+	track_peak real;
+`)


Can you please add a rg_ prefix to these columns?

deluan · 2023-01-17T00:31:41Z

model/mediafile.go

+	AlbumGain            float64 `structs:"album_gain" json:"albumGain"`
+	AlbumPeak            float64 `structs:"album_peak" json:"albumPeak"`
+	TrackGain            float64 `structs:"track_gain" json:"trackGain"`
+	TrackPeak            float64 `structs:"track_peak" json:"trackPeak"`


Same here, please add a RG prefix (ex: RGAlbumGain)

deluan · 2023-01-17T00:33:21Z

scanner/metadata/metadata.go

+func (t Tags) AlbumGain() float64 { return t.getGainValue("replaygain_album_gain") }
+func (t Tags) AlbumPeak() float64 { return t.getPeakValue("replaygain_album_peak") }
+func (t Tags) TrackGain() float64 { return t.getGainValue("replaygain_track_gain") }
+func (t Tags) TrackPeak() float64 { return t.getPeakValue("replaygain_track_peak") }
+


Same here (prefix RG)

deluan · 2023-01-17T00:47:13Z

ui/src/common/SongInfo.js

-  },
-})
+const useStyles = config.enableReplayGain
+  ? makeStyles({


There's a better (more MUI) way to achieve this. Ex:

navidrome/ui/src/common/SongDatagrid.js

Line 48 in 31c598d

visibility: (props) => (props.isDesktop ? 'hidden' : 'visible'),

kgarner7 · 2023-01-17T04:32:41Z

Additional feature: ability to toggle preamp gain

kgarner7 · 2023-01-17T05:13:13Z

ui/src/i18n/en.json

+                    "none": "Disabled",
+                    "album": "Normalize albums",
+                    "track": "Normalize tracks"
+                }


Suggestions for better descriptions here are appreciated

I'd prefer "Use Album Gain" and "Use Track Gain".
Thats f.e. how the DSub Android Client states it

Yep, makes sense @metalheim

* ReplayGain support - extract ReplayGain tags from files, expose via native api - use metadata to normalize audio in web player * make pre-push happy * remove unnecessary prints * remove another unnecessary print * add tooltips, see metadata * address comments, use settings instead * remove console.log * use better language for gain modes

github-actions · 2023-03-07T01:15:44Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

deluan force-pushed the master branch from a0971c5 to 03640ca Compare November 29, 2022 19:48

kgarner7 added 5 commits December 6, 2022 20:55

ReplayGain support

d3545a5

- extract ReplayGain tags from files, expose via native api - use metadata to normalize audio in web player

make pre-push happy

d64f6ab

remove unnecessary prints

25349b9

remove another unnecessary print

27b97f4

add tooltips, see metadata

8f62907

kgarner7 force-pushed the replaygain branch from 0fefe33 to 8f62907 Compare December 7, 2022 01:56

deluan requested changes Jan 17, 2023

View reviewed changes

kgarner7 added 2 commits January 16, 2023 23:24

address comments, use settings instead

3cbfbef

Merge remote-tracking branch 'upstream/master' into replaygain

bb0b683

remove console.log

8795d07

kgarner7 commented Jan 17, 2023

View reviewed changes

kgarner7 requested a review from deluan January 17, 2023 05:36

use better language for gain modes

a965bca

deluan approved these changes Jan 17, 2023

View reviewed changes

deluan merged commit 7152959 into navidrome:master Jan 17, 2023

deluan mentioned this pull request Jan 18, 2023

Volume normalization (in web player) #233

Closed

github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ReplayGain support + audio normalization (web player) #1988

ReplayGain support + audio normalization (web player) #1988

kgarner7 commented Nov 14, 2022 •

edited

deluan commented Nov 22, 2022

deluan commented Dec 7, 2022

kgarner7 commented Dec 7, 2022

deluan commented Dec 7, 2022

kgarner7 commented Dec 7, 2022

github-actions bot commented Dec 7, 2022 •

edited

rsammelson commented Dec 7, 2022 •

edited

deluan commented Dec 7, 2022

kgarner7 commented Dec 7, 2022

deluan commented Jan 17, 2023

kgarner7 commented Jan 17, 2023

deluan left a comment

deluan Jan 17, 2023

deluan Jan 17, 2023

deluan Jan 17, 2023

deluan Jan 17, 2023 •

edited

kgarner7 commented Jan 17, 2023

kgarner7 Jan 17, 2023

metalheim Jan 17, 2023

deluan Jan 17, 2023

github-actions bot commented Mar 7, 2023

ReplayGain support + audio normalization (web player) #1988

ReplayGain support + audio normalization (web player) #1988

Conversation

kgarner7 commented Nov 14, 2022 • edited

deluan commented Nov 22, 2022

deluan commented Dec 7, 2022

kgarner7 commented Dec 7, 2022

deluan commented Dec 7, 2022

kgarner7 commented Dec 7, 2022

github-actions bot commented Dec 7, 2022 • edited

rsammelson commented Dec 7, 2022 • edited

deluan commented Dec 7, 2022

kgarner7 commented Dec 7, 2022

deluan commented Jan 17, 2023

kgarner7 commented Jan 17, 2023

deluan left a comment

Choose a reason for hiding this comment

deluan Jan 17, 2023

Choose a reason for hiding this comment

deluan Jan 17, 2023

Choose a reason for hiding this comment

deluan Jan 17, 2023

Choose a reason for hiding this comment

deluan Jan 17, 2023 • edited

Choose a reason for hiding this comment

kgarner7 commented Jan 17, 2023

kgarner7 Jan 17, 2023

Choose a reason for hiding this comment

metalheim Jan 17, 2023

Choose a reason for hiding this comment

deluan Jan 17, 2023

Choose a reason for hiding this comment

github-actions bot commented Mar 7, 2023

kgarner7 commented Nov 14, 2022 •

edited

github-actions bot commented Dec 7, 2022 •

edited

rsammelson commented Dec 7, 2022 •

edited

deluan Jan 17, 2023 •

edited