Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(audioplayer): Enable swapping the love button for a rating field - #2488 #2510

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

zerovox
Copy link

@zerovox zerovox commented Sep 6, 2023

Closes #2488

Description: Allow the user to toggle between None/Love/Ratings as options for the player rating control.

Changes: Adds a setting (stored in local storage) for picking which rating control to display in the player.

Screenshots or Videos:

Screenshot 2023-09-06 at 4 56 43 PM

Screenshot 2023-09-06 at 4 56 31 PM

@github-actions
Copy link

Download the artifacts for this pull request:

Copy link

github-actions bot commented Mar 9, 2024

This PR has been automatically marked as stale because it has not had recent activity. The resources of the Navidrome team are limited, and so we are asking for your help.
Please check https://github.com/navidrome/navidrome/blob/master/CONTRIBUTING.md#pull-requests and verify that this code contribution fits with the description. If yes, tell it in a comment.
This PR will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@github-actions github-actions bot added the stale label Mar 9, 2024
@github-actions github-actions bot closed this Apr 8, 2024
@deluan deluan reopened this Apr 13, 2024
@deluan
Copy link
Member

deluan commented Apr 13, 2024

Hey @zerovox sorry for the delay in reviewing this. I'm avoiding adding more features to the UI as we are trying to spent most efforts on the new one, but this seems to be a nice addition.

One request though: Can you add an option to show both Love and Rating in the player bar, similar to @celynw's PR (#2879)? If you can't work on that right now, please let me know and maybe @celynw can try it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants