-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artist discography sorted own-albums-first #2580
base: master
Are you sure you want to change the base?
Conversation
Sort by Artist = Album Artist first, so it shows an artist's own albums first, and appearances on other albums second.
Alias match_album_artist, allows for sorting by an artist's own albums first, then his appearances on compilations/etc.
forgot args in line 89
prettier
prettier
reformatted
removed comment about Subsonic, it's irrelevant since this query is never done through the Subsonic API.
merge upstream changes
Fix EnableMediaFileCoverArt option default value
merge upstream
Upgrade to Go 1.21 (navidrome#2475)
merge upstream
Download the artifacts for this pull request: |
I think this would be better handled completely on the client. This change is too "hacky" as it depends on "virtual" sort fields. To give some context, I already regret resorting to this in other parts of the code. It makes things too magical. |
Allright, I'll have a look if I can do this completely in the WebUI - it may become less magical, but I'm not sure if the result will be more readable... |
this is now done upstream, in metadata/metadata.go
Fix for #2214
This sorts an artist's discography (Artist view) first by his own albums (Artist = Album Artist), then by his appearances (Artist != AlbumArtist).
(this is a re-submit of #2413 - I didn't realise that renaming the branch upstream automatically closes the PR)