Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: New scanner #2709

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

WIP: New scanner #2709

wants to merge 10 commits into from

Conversation

deluan
Copy link
Member

@deluan deluan commented Dec 15, 2023

⚠️ This is very experimental code and will break your DB if you run it locally! If you want to try it for any reason, be sure to backup your DB first! ⚠️

This is the branch/PR that holds the new Scanner implementation. Goals for this new scanner:

Copy link

github-actions bot commented Dec 15, 2023

Download the artifacts for this pull request:

@deluan deluan force-pushed the new-scanner branch 4 times, most recently from c53d1bf to f68f9b7 Compare December 16, 2023 18:41
@deluan deluan mentioned this pull request Dec 16, 2023
3 tasks
@deluan deluan changed the title New scanner WIP: New scanner Dec 18, 2023
@deluan deluan force-pushed the new-scanner branch 8 times, most recently from f5e98f0 to a7af130 Compare December 20, 2023 23:34
@tty228
Copy link

tty228 commented Dec 21, 2023

INFO[0127] Scanner: Starting scan                        fullRescan=true numLibraries=1
DEBU[0127] Scanner: Found folder                         _path=/home/****/GitHub/navidrome/music/1 audioCount=1 folder=1 hasPlaylist=false images="[]"
DEBU[0127] Scanner: Found folder                         _path=/home/****/GitHub/navidrome/music audioCount=4 folder=music hasPlaylist=false images="[]"
DEBU[0127] Scanner: Found folder                         _path=/home/****/GitHub/navidrome/music/2 audioCount=1 folder=2 hasPlaylist=false images="[]"
INFO[0127] Scanner: Finished scanning all libraries      duration="713.296µs"

1234

I attempted to scan songs, and the logs indicate that music files were found, but the song list is not displayed in the UI.

Version
0.50.1-SNAPSHOT (e8adcda) from https://github.com/navidrome/navidrome/actions/runs/7281968279

How Navidrome is installed?
navidrome_linux_amd64_linux_amd64_v1

Environment

  • OS: pre-built binary (ubuntu-22.04.3)
  • Browser: Firefox
  • Client: Web interface

@deluan
Copy link
Member Author

deluan commented Dec 21, 2023

Hey @tty228, thanks for trying it out, but... WIP = Work In Progress 🙃

The work is far from being in a usable state. I created this branch to have a docker image available for my own tests. When it is usable, I'll change the description and will ask feedback in our Discord dev channel.

@deluan deluan force-pushed the new-scanner branch 2 times, most recently from 4f61c0a to ef51ff6 Compare December 22, 2023 00:27
@tty228
Copy link

tty228 commented Dec 22, 2023

Thank you for your reply. I was just curious and gave it a try. I mistakenly thought this was a version that required testing and feedback. 😆

@deluan deluan force-pushed the new-scanner branch 9 times, most recently from 56e2c95 to 89b0e9e Compare December 27, 2023 17:54
log/log.go Fixed Show fixed Hide fixed
log/log.go Fixed Show fixed Hide fixed
@deluan deluan force-pushed the new-scanner branch 2 times, most recently from 845f33c to e3860c2 Compare May 20, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants