Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/lastfm use album artist #2909

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

felipemarinho97
Copy link

Adding a config to allow scrobble the albumArtist instead of artist. This is because some songs with various artists are being scrobbled wrongly.

Now (artist tag):
Screenshot from 2024-03-14 08-54-20

With the albumArtist:
Screenshot from 2024-03-14 08-53-34

This change do not break anything. The default value for UseAlbumArtist is false.

Also, I dind't find where I can update these docs (https://www.navidrome.org/docs/usage/configuration-options/).

@certuna
Copy link
Contributor

certuna commented Mar 18, 2024

This will introduce wrong scrobbles for tracks from compilation albums that have the compiler or DJ credited as the Album Artist, like Jamiroquai - LateNightTales or Bob Stanley & Pete Wiggs - Winter Of Discontent.

IMO this problem will solve itself when Navidrome will support multiple artists (this is planned, @deluan is working on the database refactoring that makes this possible), then you could write an option for the scrobbler code to choose between the first Artist of the array ("Bob", "Alice") or the whole Artist string ("Bob feat. Alice")

@felipemarinho97
Copy link
Author

This will introduce wrong scrobbles for tracks from compilation albums that have the compiler or DJ credited as the Album Artist, like Jamiroquai - LateNightTales or Bob Stanley & Pete Wiggs - Winter Of Discontent.

IMO this problem will solve itself when Navidrome will support multiple artists (this is planned, @deluan is working on the database refactoring that makes this possible), then you could write an option for the scrobbler code to choose between the first Artist of the array ("Bob", "Alice") or the whole Artist string ("Bob feat. Alice")

Well, this is a trade off.. If you listen to a lot of compilations and care about it, just leave the config UseAlbumArtist as false (this is the default).

@inalone
Copy link

inalone commented Mar 22, 2024

Great work - I'd love this in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants