Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip service container for empty image #2281

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Conversation

GitBluub
Copy link
Contributor

@GitBluub GitBluub commented Apr 8, 2024

It is used to skip empty image name in services which is the only way to handle conditional services in github action currently, see actions/runner#822
Prints the same information message as well

@GitBluub GitBluub requested a review from a team as a code owner April 8, 2024 14:58
ChristopherHX
ChristopherHX previously approved these changes Apr 8, 2024
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

mergify bot commented Apr 8, 2024

@GitBluub this pull request has failed checks 🛠

I dislike the codecov action, but are too lazy / unable to generate a token and refactor the workflow

@mergify mergify bot added the needs-work Extra attention is needed label Apr 8, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.32%. Comparing base (5a80a04) to head (279ddb8).
Report is 80 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2281       +/-   ##
===========================================
+ Coverage   61.56%   76.32%   +14.76%     
===========================================
  Files          53       61        +8     
  Lines        9002     7815     -1187     
===========================================
+ Hits         5542     5965      +423     
+ Misses       3020     1295     -1725     
- Partials      440      555      +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

mergify bot commented Apr 10, 2024

@GitBluub this pull request has failed checks 🛠

Copy link
Contributor

mergify bot commented Apr 15, 2024

@GitBluub this pull request has failed checks 🛠

@ChristopherHX
Copy link
Contributor

info - 2024-04-15 12:51:17,734 -- Process Commit creating complete
error - 2024-04-15 12:51:17,734 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 375 seconds."}

I really need to fix the pipeline, waiting 15min to see that failure randomly is so bad... (I'm not authorized to merge without all checks green and another reviewer)

Copy link
Contributor

mergify bot commented Apr 15, 2024

@GitBluub this pull request has failed checks 🛠

2 similar comments
Copy link
Contributor

mergify bot commented May 13, 2024

@GitBluub this pull request has failed checks 🛠

Copy link
Contributor

mergify bot commented May 29, 2024

@GitBluub this pull request has failed checks 🛠

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 4, 2024
It is used to skip empty image name in services which is the only way to handle condition services in github action currently actions/runner#822
@mergify mergify bot removed the needs-work Extra attention is needed label Jun 4, 2024
@mergify mergify bot requested a review from a team June 4, 2024 13:01
ChristopherHX
ChristopherHX previously approved these changes Jun 4, 2024
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing tests

pkg/runner/testdata/services-empty-image/push.yaml Outdated Show resolved Hide resolved
@mergify mergify bot merged commit e4607fc into nektos:master Jun 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants