fix: Broken IME enable and popup position #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason it won't properly get enabled otherwise
This was referenced May 19, 2024
|
I went ahead and merged this, so we can prepare a release. |
|
It looks like these fixes it causes a lot of crashes in |
zbyna
pushed a commit
to zbyna/neovide
that referenced
this pull request
Jun 1, 2024
* Apply IME enable status on every event processed For some reason it won't properly get enabled otherwise * Fix the IME position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
The IME enable state, is now called before each event is processed. For some reason it does not apply properly otherwise. That's also what was done before Neovide 0.13.
The position is also fixed, it used the grid position instead of the physical position before. I also fixed the one line offset bug, and a bug where the position is incorrect when starting the editing.
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.