WIP: Support for Canonical Snap builds to run on Ubuntu Core #17199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This minimal snap downloads the kickstart.sh script during the pull stage, executes the script without starting the Agent, and then ensures it is properly packed. This only awards the `network` and `network-bind` plugs to the Agent, and the `network` plug for the claim script.
This includes many `disk.*` metrics, cpu and memory pressure, `system.io`.
This includes `ip.*`, `ipv4.*`, `ipv6.*`, `wireless.*` and `netfilter.conntrack_sockets`.
This is the only plug that provides wide read access to other processes' properties, opening up proper metrics on file descriptors and limits. However, I don't think this is proper and `snapd` should expose another way to get this type of access, because it isn't necessarily beholden to using Docker.
|
I'm still working on figuring out which interfaces provide enough permissions to the Agent. Among other things, |
This enables `cgroups.plugin` to access unified cgroups files in `/sys/fs/cgroup` and emit metrics for cgroups of various kinds, including systemd services. Note that systemd user slices (and their child slices) are disabled by default by the plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide the ability to create a Snap package for Netdata Agent and associated utilities.
Test Plan
TBD
Additional Information
This worked is based on a request for supporting Ubuntu Core, which is primarily used in IoT settings, but is also the framework within which (most) Snaps run.
This PR takes a different approach than #1991, in that instead of a full build as part of the snapcraft building process, it takes the static builds and packages them. That PR had a request to move the
snapdirectory to another place than the root of the repo, but snapcraft makes this very hard, and if we decide to make a huge point on this, there may be some avenues I can try, but it most likely means that the YAML file will be.snapcraft.yamland other things like hooks need to be populated explicitly.The major issue with running the Agent in this environment is providing sufficient permissions in the strict confinement model, through so-called plugs for interfaces.