Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move vendoring of Fluent-Bit to CMake. #17523

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Ferroin
Copy link
Member

@Ferroin Ferroin commented Apr 25, 2024

Summary
  • Move the actual code for building the fluent-bit shared library into CMake.
  • Switch from using a submodule to using an external project via FetchContent.
  • Handle installation of the shared library in CMake as well.
  • Correctly package the shared library for our native packages.
Test Plan

CI passes on this PR

Additional Information

This is the last external project handled outside of our build system. There are a few cases that are within our build system that we ideally should be handling differently than we currently are, but fixing those is a separate project that is lower priority.

@github-actions github-actions bot added area/packaging Packaging and operating systems support area/build Build system (autotools and cmake). area/logs-management labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build system (autotools and cmake). area/logs-management area/packaging Packaging and operating systems support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant