New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of OpenSSL linking on macOS #17535
Open
Ferroin
wants to merge
7
commits into
netdata:master
Choose a base branch
from
Ferroin:macos-ssl-ci-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+59
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferroin
changed the title
Pull in all dependencies for macOS CI jobs.
Fix handling of OpenSSL linking on macOS
Apr 26, 2024
Ferroin
force-pushed
the
macos-ssl-ci-fix
branch
2 times, most recently
from
April 26, 2024 13:58
d3984e9
to
8d4be59
Compare
Ferroin
force-pushed
the
macos-ssl-ci-fix
branch
2 times, most recently
from
May 3, 2024 14:39
53ad3f5
to
feab040
Compare
thiagoftsm
previously approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On FreeBSD. the nearest I can be from macOS, everything worked as expected. PR compiled, dbengine is working as expected, and I can see host on cloud. LGTM!
Rebased to resolve merge conflicts. |
thiagoftsm
reviewed
May 16, 2024
Instead of only pulling in a basic set.
It happened to be working before without this because we weren’t hitting any edge cases, but the use of IMPORTED targets with PkgConfig requires these fixes to behave correctly for transitive dependencies in static builds.
Rebased to pick up the latest changes in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
CI passes on this PR.