fix(profile): Avoid updating the config at each call

[solracsf]

Summary

Updating the config at each call can be inefficient. Instead, check if the merged configuration is different from the existing one before performing the update. This optimization may reduce unnecessary database operations.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[ChristophWurst]

had to check if php considers two array identical but seems to be the case 👍 https://3v4l.org/oGKFE

[ChristophWurst]

The magic setter of an entity should already skip assignments when the value does not change:

server/lib/public/AppFramework/Db/Entity.php

Lines 108 to 110 in 474cbda

	if ($args[0] === $this->$name) {
	return;
	}

. The mapper skips the UPDATE query if there are no updated fields:

server/lib/public/AppFramework/Db/QBMapper.php

Lines 184 to 187 in 474cbda

	$properties = $entity->getUpdatedFields();
	if (\count($properties) === 0) {
	return $entity;
	}

.

Hence I wonder if the UPDATE is actually run before your changes. And if so, why. Possible causes

1. The arrays are not identical, or the json representation isnt.
2. Other fields of the config are assigned.

Could you check?

[solracsf]

You're right, in our case one extension was causing fields updates on the fly. Disabling it fixed those chatty DB queries.
So closing this, as the server behaves as it should 👍

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)