fix(dav): fall back to generated avatar in image export plugin #45408
Conversation
st3iny
added
3. to review
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
fix/dav/image-export-plugin-fallback
branch
from
6f4841c
to
21a5dc8
Compare
st3iny
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ))); | ||
| $server->addPlugin(new \OCA\DAV\CardDAV\ImageExportPlugin( | ||
| new \OCA\DAV\CardDAV\PhotoCache( | ||
| \OC::$server->getAppDataDir('dav-photocache'), |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
| $avatar = $this->avatarManager->getGuestAvatar($name); | ||
| $image = $avatar->get($size); | ||
|
|
||
| $response->setHeader('Content-Type', $image->mimeType()); |
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
| $avatar = $this->avatarManager->getGuestAvatar($name); | ||
| $image = $avatar->get($size); | ||
|
|
||
| $response->setHeader('Content-Type', $image->mimeType()); |
Check notice
Code scanning / Psalm
PossiblyFalseReference Note
| $image = $avatar->get($size); | ||
|
|
||
| $response->setHeader('Content-Type', $image->mimeType()); | ||
| $fileName = $node->getName() . '.' . PhotoCache::ALLOWED_CONTENT_TYPES[$image->mimeType()]; |
Check notice
Code scanning / Psalm
PossiblyNullArrayOffset Note
| $fileName = $node->getName() . '.' . PhotoCache::ALLOWED_CONTENT_TYPES[$image->mimeType()]; | ||
| $response->setHeader('Content-Disposition', "attachment; filename=$fileName"); | ||
| $response->setStatus(200); | ||
| $response->setBody($image->data()); |
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
| $logger) | ||
| $this->server->addPlugin( | ||
| new ImageExportPlugin(new PhotoCache( | ||
| \OC::$server->getAppDataDir('dav-photocache'), |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
Summary
TODO
Checklist