-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autocomplete): controlled state logic #2969
base: canary
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 06dbf22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@chirokas is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
Warning Rate Limit Exceeded@jrgarciadev has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 56 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThis update introduces a crucial patch to the Changes
Assessment against linked issues
The modifications in the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- .changeset/proud-moles-fix.md (1 hunks)
- packages/components/autocomplete/tests/autocomplete.test.tsx (3 hunks)
- packages/components/autocomplete/src/use-autocomplete.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- .changeset/proud-moles-fix.md
Additional comments not posted (3)
packages/components/autocomplete/__tests__/autocomplete.test.tsx (2)
51-63
: TheControlledAutocomplete
component is well-implemented for testing controlled behavior.
268-290
: The test case "should work when key equals textValue (controlled)" is correctly implemented to verify the component's behavior in a controlled environment.packages/components/autocomplete/src/use-autocomplete.ts (1)
311-311
: The modification to the condition inuseAutocomplete
correctly prevents unnecessary state updates when the labels and keys are identical.
packages/components/autocomplete/__tests__/autocomplete.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @chirokas
Closes #2955
📝 Description
Revise autocomplete controlled state logic.
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit