fix(datepicker): config not applied #4698
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 14, 2024 08:38
Global config is not applied to datepicker if startDate is set before ngOnInit is called. Fixes ng-bootstrap#4697
NgbInputDatepickerConfig does not affect child datepicker because NgbInputDatepicker does not confer its injector Fixes ng-bootstrap#3848
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the proposed fix for #4697 will not resolve the issue when
NgbDatepicker.navigateTo()is called manually, only when it is called by setting the[startDate]input. It seems reasonable to expect users not to call functions on components before they're initialized, so I believe this fix to be sufficient. That said, I'm more than happy to hear any feedback.Fixes #4697
Fixes #3848