Only schedule non-empty username+password for retry #2792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
doAuthenticate
function fails during connection,thread_data.username
andthread_data.password
variables are still empty.Later, when
BruteSocket
'scheckStatus
is invoked, it tries to save those values for later retry. However, as both username and password are still empty at this point,retry_accounts
will have anil, nil
item.When this item is picked up in the next invocation of
doAuthenticate
, as both username and password arenil
,initial_accounts_exhausted
is set to true, and the scanning stops.This change adds a condition, to only add a new item to
retry_accounts
in thecheckStatus
function, if either the username or the password is notnil
.