Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some bugfixes and a TextControl editor as a popup #384

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Banbury
Copy link

@Banbury Banbury commented Apr 25, 2014

This fixes some bugs on Windows with two button mouses.
Additionally I have implemented the TextControl as a popup using JIDE.

Sorry for the line endings. I didn't realize it, before it was too late. I added a .gitattributes file, that should fix this for future commits.

@Banbury
Copy link
Author

Banbury commented Apr 26, 2014

I have added a triangular grid node (TriGrid).

The icon was created in Nodebox with the TriGrid node itself.

@fdb
Copy link
Member

fdb commented Apr 26, 2014

Hi,

Thanks for the contributions!

The line ending stuff is a bit unfortunate since it's hard to see what's changed.

I would suggest in the future breaking this up in multiple PRs so I can look at them separately. For now, I'll look at the commits separately and cherry-pick them.

I'm currently travelling so I don't have much time to work on this in the coming days but I'll keep you updated.

Best,

F

@Banbury
Copy link
Author

Banbury commented Apr 26, 2014

I'm truly sorry for the line breaks. It won't happen again. And I tried to keep the pull requests apart, but github persists in combining them.
Nodebox is a great program. I was looking for exactly something like that for years.

@Banbury
Copy link
Author

Banbury commented Apr 27, 2014

Some more small fixes and a few new nodes.

The build server doesn't seem to like the launch4j maven plugin. It's not needed for the rest of my commits. I just prefer it over NSIS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants