Ram nodebox/sockets 4 #429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added webSocket classes and plugged them into Network Functions
Command structure in plcae to control app
… automatically deal with disconections etc
fdb
reviewed
Dec 23, 2016
| @@ -1,8 +1,18 @@ | |||
| package nodebox.function; | |||
|
|
|||
| import com.sun.org.apache.xerces.internal.impl.dv.xs.BooleanDV; | |||
| import com.sun.org.apache.xpath.internal.operations.Bool; | |||
There was a problem hiding this comment.
These two imports use proprietary, internal code. I don't think you use them inside of the code. Remove?
fdb
reviewed
Dec 23, 2016
| */ | ||
|
|
||
| @ClientEndpoint | ||
| public class webSocketClientEndpoint { |
There was a problem hiding this comment.
Classes should start with a capital letter (e.g. WebSocketClientEndpoint)
fdb
reviewed
Dec 23, 2016
| public Session call() throws Exception { | ||
| try { | ||
| WebSocketContainer container = ContainerProvider.getWebSocketContainer(); | ||
| return(container.connectToServer(annotatedEndpointInstance, uri)); |
There was a problem hiding this comment.
This line causes the code to fail compiling. This is the error I get:
webSocketClientEndpoint.java:45: error: local variable annotatedEndpointInstance is accessed from within inner class; needs to be declared final
[javac] return(container.connectToServer(annotatedEndpointInstance, uri));
|
Thanks for the PR. However, I couldn't get it to compile -- see the inline notes for more details (this is on Linux with OpenJDK 8). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is my first pull request and I'm a git noob so bear with me. It's also my first Java project.
Main change is for various upgrades the project is now on Java 8
Most of the changes are in:
nodebox/src/main/java/nodebox/network/
This is where all the WebSocket code is. WebSocketMessaging.java is for static access from graph nodes. Each open document has an instance of webSocketClientEndpoint.java for commands etc.
I've added some docs here:
nodebox/src/main/java/nodebox/network/README.md
And all the messaging strings are defined here:
nodebox/src/main/java/nodebox/network/WSDefs.java
Added the new nodes and JSON functions here:
nodebox/src/main/java/nodebox/function/NetworkFunctions.java
Various threading fixes, added logic to enable sockets
nodebox/src/main/java/nodebox/client/NodeBoxDocument.java
Added logic to enable sockets
nodebox/src/main/java/nodebox/client/Application.java