New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing sshKeyMemoryNew to Cred #1973

Open

tkmcmaster wants to merge 1 commit into nodegit:master from tkmcmaster:sshKeyMemoryNewDeprecated

tkmcmaster commented Mar 3, 2023 •

edited

Closes #1962

While Git.Credential.sshKeyMemoryNew works, the deprecated Git.Cred is missing sshKeyMemoryNew breaking backwards compatibility.

import Git from "nodegit";

Object.keys(Git.Cred): ["defaultNew","sshKeyFromAgent","sshKeyNew","usernameNew","userpassPlaintextNew","TYPE"]

Object.keys(Git.Credential): ["defaultNew","sshKeyFromAgent","sshKeyMemoryNew","sshKeyNew","usernameNew","userpassPlaintextNew","getSelfFreeingInstanceCount","getNonSelfFreeingConstructedCount","TYPE"]


          Added missing sshKeyMemoryNew to Cred

f08a6f1

Fixes nodegit#1962

tkmcmaster mentioned this pull request

"sshKeyMemoryNew" is not found in Typescript #1962

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment