Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix --v8-lite-mode build #52725

Merged
merged 1 commit into from
Jun 3, 2024
Merged

build: fix --v8-lite-mode build #52725

merged 1 commit into from
Jun 3, 2024
+10 −8

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Apr 27, 2024

Fixes: #52710

This patch modifies the build config to compile the error-causing files under the v8_enable_webassembly condition.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Apr 27, 2024
@davidfiala
Copy link

Thank you!

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58779/

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@daeyeon
Copy link
Member Author

daeyeon commented Apr 29, 2024

https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5945/

The CI test error seems to require a fix for #51308.

12:20:46     1480c755c560 8 JS:~functionTwo /home/iojs/build/workspace/node-test-commit-v8-linux/test/fixtures/linux-perf-logger.js:13:21
12:20:46     1480c755c600 3c JS:~functionOne /home/iojs/build/workspace/node-test-commit-v8-linux/test/fixtures/linux-perf-logger.js:7:21
12:20:46     
12:20:46     </end perf map content>
12:20:46     
12:20:46         at runSuite (/home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf-logger.js:145:10)
12:20:46         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf-logger.js:148:1)
12:20:46         at Module._compile (node:internal/modules/cjs/loader:1476:14)
12:20:46         at Module._extensions..js (node:internal/modules/cjs/loader:1555:10)
12:20:46         at Module.load (node:internal/modules/cjs/loader:1288:32)
12:20:46         at Module._load (node:internal/modules/cjs/loader:1104:12)
12:20:46         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:191:14)
12:20:46         at node:internal/main/run_main_module:30:49 {
12:20:46       generatedMessage: false,
12:20:46       code: 'ERR_ASSERTION',
12:20:46       actual: 2,
12:20:46       expected: 0,
12:20:46       operator: 'strictEqual'
12:20:46     }
12:20:46     
12:20:46     Node.js v23.0.0-pre
12:20:46   ...
12:20:46 
12:20:46 Failed tests:
12:20:46 out/Release/node /home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf-logger.js
  ...

Failed tests:
out/Release/node /home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf-logger.js

@davidfiala davidfiala mentioned this pull request May 27, 2024
Open
@daeyeon
build: fix --v8-lite-mode build
46be09a 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
@daeyeon daeyeon force-pushed the main.build-240428.Sun.5116 branch from dd1048e to 46be09a Compare June 3, 2024 01:56
@daeyeon daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 3, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6016/

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6016/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59628/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6017/

@daeyeon
Copy link
Member Author

daeyeon commented Jun 3, 2024

Rebased the latest main and all tests are green. Please review once more. @anonrig @lpinca @richardlau

@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Jun 3, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 3, 2024
@nodejs-github-bot nodejs-github-bot merged commit 58711c2 into nodejs:main Jun 3, 2024
60 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 58711c2

targos pushed a commit that referenced this pull request Jun 3, 2024
@daeyeon @targos
build: fix --v8-lite-mode build
0976439 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #52725
Fixes: #52710
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v22.0.0 breaks --v8-lite-mode build missing action for js-to-wasm-tq-csa.cc
6 participants
@daeyeon @nodejs-github-bot @davidfiala @lpinca @anonrig @richardlau