build: improve makefile to be os agnostic #52866
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
anonrig
force-pushed
the
fix-windows-makefile
branch
3 times, most recently
from
4ca1542
to
9d29211
Compare
anonrig
force-pushed
the
fix-windows-makefile
branch
from
9d29211
to
958f0fd
Compare
|
cc @nodejs/platform-windows @lemire can you take a look? |
lemire
reviewed
May 8, 2024
| ifeq ($(OS),Windows_NT) | ||
| OSTYPE := windows | ||
|
|
||
| ifeq ($(PROCESSOR_ARCHITEW6432),AMD64) |
There was a problem hiding this comment.
This looks wrong to me. You compare against AMD64 and if so, you set arm64, and so forth.
There was a problem hiding this comment.
I think that this was meant to be ARM64?
lemire
reviewed
May 8, 2024
| ifeq ($(OS),Windows_NT) | ||
| OSTYPE := windows | ||
|
|
||
| ifeq ($(PROCESSOR_ARCHITEW6432),AMD64) |
There was a problem hiding this comment.
Suggested change
| ifeq ($(PROCESSOR_ARCHITEW6432),AMD64) | |
| ifeq ($(PROCESSOR_ARCHITEW6432),ARM64) |
lemire
reviewed
May 8, 2024
| ARCHTYPE := arm64 | ||
| else | ||
| ifeq ($(PROCESSOR_ARCHITECTURE),AMD64) | ||
| ARCHTYPE := arm64 |
There was a problem hiding this comment.
Suggested change
| ARCHTYPE := arm64 | |
| ARCHTYPE := amd64 |
|
Unrelated to this PR, but do we build Node for Windows ARM64 in CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For certain vsbuild.bat actions, it executes makefile and on PowerShell it was throwing error for me because
unamedoesn't exist. This pull-request doesn't solve all Windows related issues in makefile but makes the terminal output a lot cleaner.cc @nodejs/platform-windows @nodejs/build