Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x backport] test_runner: support source mapped test locations #52872

Closed
wants to merge 2 commits into from
Closed

[v20.x backport] test_runner: support source mapped test locations #52872

wants to merge 2 commits into from

Commits on May 7, 2024

  1. test_runner: support source mapped test locations 

    This commit adds support for source mapping test locations
when the --enable-source-maps flag is present.

Fixes: nodejs#51392
PR-URL: nodejs#52010
Fixes: nodejs#51610
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    @cjihrig @MoLow
    cjihrig authored and MoLow committed May 7, 2024
    Configuration menu
    Copy the full SHA
    bdeaafd View commit details
    Browse the repository at this point in the history

  2. test_runner: use paths for test locations 

    This commit transforms test locations to paths when V8 provides
file URLs (which seems to be for ESM files).

Fixes: nodejs#51610
PR-URL: nodejs#52010
Fixes: nodejs#51392
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    @cjihrig @MoLow
    cjihrig authored and MoLow committed May 7, 2024
    Configuration menu
    Copy the full SHA
    2eac413 View commit details
    Browse the repository at this point in the history