Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v21.x backport] test: move http to subfolder #52902

Closed

Conversation

RedYetiDev
Copy link
Member

@RedYetiDev RedYetiDev commented May 8, 2024

Backport of #52875
Blocked by #52901

This PR moves all of the parallel/test-http-* files into parallel/http/test-*. If this change goes well, I look to implement it throughout the entire parallel folder (one subsystem at a time)

IMO, the DX will be much easier with this change, as searching through tests will become simpler, as users can simply visit the test/parallel/<subsystem> directory.

From a maintenance point of view, CODEOWNERS and label rules should be simpler, as a subdirectory now exists for these subsystems.

The http subsystem is largest subsystem (in number of test files), so I decided to handle it first.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v21.x v21.x Issues that can be reproduced on v21.x or PRs targeting the v21.x-staging branch. labels May 8, 2024
@RedYetiDev RedYetiDev changed the title test: move http to subfolder test: move http to subfolder (Backport v21) May 8, 2024
@RedYetiDev RedYetiDev added the blocked PRs that are blocked by other issues or PRs. label May 8, 2024
@RedYetiDev
Copy link
Member Author

@nodejs/backporters
@nodejs/testing

@RedYetiDev
Copy link
Member Author

Linter and other tests may fail for this PR until the blocking PR (#52901) lands.

@marco-ippolito marco-ippolito changed the title test: move http to subfolder (Backport v21) [v21.x] test: move http to subfolder May 8, 2024
@marco-ippolito marco-ippolito changed the title [v21.x] test: move http to subfolder [v21.x backport] test: move http to subfolder May 8, 2024
@marco-ippolito
Copy link
Member

Why backporting on v21? I dont think we are going to release a new v21 unless its a security release

@RedYetiDev
Copy link
Member Author

Why backporting on v21? I dont think we are going to release a new v21 unless its a security release

Oh, right, I'll backport to v20 instead. Even so, #52901 needs to land first.

@RedYetiDev RedYetiDev closed this May 8, 2024
@RedYetiDev RedYetiDev deleted the http-subfolder-staging branch May 8, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PRs that are blocked by other issues or PRs. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v21.x v21.x Issues that can be reproduced on v21.x or PRs targeting the v21.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants