Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: sync NODE_REPL_EXTERNAL_MODULE and kDisableNodeOptionsEnv #52905

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

src: sync NODE_REPL_EXTERNAL_MODULE and kDisableNodeOptionsEnv #52905

wants to merge 2 commits into from
+38 −2

Conversation

RafaelGSS
Copy link
Member

Fixes: #51227

Currently, I'm throwing kBootstrapError, but I'm almost sure this is not the appropriate error. In this case, should I create a new error?

Technically, this is a fix for kDisableNodeOptionsEnv, but it can be considered a breaking change for the ones relying on the current behavior (which is unlikely).

@RafaelGSS RafaelGSS requested a review from joyeecheung May 8, 2024 17:55
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 8, 2024
@RedYetiDev
Copy link
Member

RedYetiDev commented May 8, 2024 •
edited

IMO if it's a breaking change it should be semver-minor or notable-change

(But as a triage member, this isn't my decision, nor my place)

@RedYetiDev RedYetiDev added the repl Issues and PRs related to the REPL subsystem. label May 8, 2024
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2024
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/9008046172

@RafaelGSS RafaelGSS removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label May 9, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59055/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59062/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59085/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59173/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59198/

Trott
Trott approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No opinion from me on semver for this, but the code change LGTM.

Trott
Trott reviewed May 14, 2024
View reviewed changes
doc/api/cli.md
Comment on lines +2783 to +2853
changes:
- version:
- REPLACEME
pr-url: https://github.com/nodejs/node/pull/52905
description:
Remove the possibility to use this env var with
kDisableNodeOptionsEnv for embedders.

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

@Trott
Copy link
Member

Trott commented May 14, 2024

No opinion from me on semver for this, but the code change LGTM.

Actually, with a little more thought, I think this is semver patch, so I agree with @RafaelGSS. But I'll defer to Releasers who think otherwise or collaborators more knowledgable about how these features are used.

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label May 14, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 14, 2024
@RedYetiDev
Copy link
Member

No opinion from me on semver for this, but the code change LGTM.

Actually, with a little more thought, I think this is semver patch

Whatever you say I'm happy with, I'm not a collaborator, so I really don't have much of an opinion (and experience) to really weigh in

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label May 16, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 16, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59247/

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59267/

@RafaelGSS RafaelGSS added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 17, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59271/

@RafaelGSS
Copy link
Member Author

I'm getting

14:08:05 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/embedtest: error while loading shared libraries: libcrypto.so.1.1: cannot open shared object file: No such file or directory

I don't see why my changes would cause this. Any idea? @nodejs/build

joyeecheung
joyeecheung approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion to add a comment in case the test needs to test NODE_OPTIONS in the future..

test/embedding/embedtest.cc
{
node::ProcessInitializationFlags::kNoInitializeV8,
node::ProcessInitializationFlags::kNoInitializeNodeV8Platform,
node::ProcessInitializationFlags::kDisableNodeOptionsEnv,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
node::ProcessInitializationFlags::kDisableNodeOptionsEnv,
// This is used to test NODE_REPL_EXTERNAL_MODULE is disabled with
// kDisableNodeOptionsEnv. If other tests need NODE_OPTIONS support in the
// future, split this configuration out as a command line option.
node::ProcessInitializationFlags::kDisableNodeOptionsEnv,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The kDisableNodeOptionsEnv option can be work around by using NODE_REPL_EXTERNAL_MODULE env
5 participants
@RafaelGSS @nodejs-github-bot @RedYetiDev @Trott @joyeecheung