doc, test: tracing channel hasSubscribers getter #52908
Open
+88
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tlhunter
commented
May 8, 2024
•
tlhunter
commented
- this adds a test and documentation for work done in diagnostics_channel: early-exit tracing channel trace methods #51915
- the public helper method was added as a convenience from patterns that emerged with Fastify and Undici
tlhunter
force-pushed
the
tlhunter/dc-tc-hassub-doc-and-test
branch
from
c79f7af
to
c76e51c
Compare
tlhunter
changed the title
RedYetiDev
reviewed
May 8, 2024
test/parallel/test-diagnostics-channel-tracing-channel-has-subscribers.spec.js
Outdated
Show resolved
Hide resolved
tlhunter
force-pushed
the
tlhunter/dc-tc-hassub-doc-and-test
branch
6 times, most recently
from
a3e08e3
to
a9a5bd6
Compare
follow up work for nodejs#51915
tlhunter
force-pushed
the
tlhunter/dc-tc-hassub-doc-and-test
branch
from
a9a5bd6
to
1c6ca0e
Compare
Qard
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.