Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove ArrayBufferAllocator::Reallocate override #52910

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: remove ArrayBufferAllocator::Reallocate override #52910

wants to merge 1 commit into from
+0 −35

Conversation

syg
Copy link
Contributor

@syg syg commented May 8, 2024

It's being deprecated and removed in V8.

See https://issues.chromium.org/u/1/issues/331326406.

@syg
src: Remove ArrayBufferAllocator::Reallocate override
560f111 
It's being deprecated and removed in V8.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 8, 2024
@syg
Copy link
Contributor Author

syg commented May 8, 2024

cc @addaleax @tniessen who were the reviewers for the related PR #52292

@syg syg changed the title src: Remove ArrayBufferAllocator::Reallocate override src: remove ArrayBufferAllocator::Reallocate override May 8, 2024
@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label May 9, 2024
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/9016827306

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59122/

@benjamingr benjamingr added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels May 12, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 12, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59140/

@syg
Copy link
Contributor Author

syg commented May 14, 2024

@benjamingr I see that I got the commit message capitalization wrong. Should I force-push with the correct capitalization? I imagine that'll need a new CI run.

@benjamingr
Copy link
Member

Hey sorry I missed that:

Should I force-push with the correct capitalization? I imagine that'll need a new CI run.

Sure, let's do that and re-run CI, it's not a rush but if it were we can land without re-running CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@syg @nodejs-github-bot @benjamingr @jasnell @addaleax