build: remove deprecated calls for argument groups #52913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
Remove calls of `add_argument_group()` where an existing argument group is passed as an argument, this is deprecated since Python 3.11.
VoltrexKeyva
force-pushed
the
rm-deprecated-calls
branch
from
a38d71d
to
4b828b4
Compare
benjamingr
approved these changes
May 9, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
May 9, 2024
VoltrexKeyva
added
the
author ready
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c70fa2c |
targos
pushed a commit
that referenced
this pull request
May 11, 2024
Remove calls of `add_argument_group()` where an existing argument group is passed as an argument, this is deprecated since Python 3.11. PR-URL: #52913 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what the purpose of these
add_argument_group()calls are that pass in an existing argument group but they are deprecated and may be removed, see the Python documentation for notice.Warning
Changed in version 3.11: Calling
add_argument_group()on anargument group is deprecated. This feature was never supported and
does not always work correctly. The function exists on the API by
accident through inheritance and will be removed in the future.