Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update styles #52922

Closed
wants to merge 2 commits into from
Closed

doc: update styles #52922

wants to merge 2 commits into from

Conversation

RedYetiDev
Copy link
Member

This PR makes some simple but visually different changes.

On the code side of things, this PR removes extra semicolons from ending properties and alphabetizes properties.

On the UI side of things, this PR animates the transition between dark and light mode, makes the cjs/mjs button smaller, and removes the underline from sidebar links.

I know @nodejs/web-infra is working on redesigning the API docs entirely, so this change will likely be overwritten, but for now, this will IMO make the docs a bit nicer.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/nodejs-website

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 9, 2024
@AugustinMauroy
Copy link
Contributor

did we minify the css on building process ???

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, We can't land this, too many changes. Please make more specific changes and explain better the motivation behind this PR. Thanks!

@ovflowd
Copy link
Member

ovflowd commented May 9, 2024

did we minify the css on building process ???

Could you rephrase? 👀

@AugustinMauroy
Copy link
Contributor

What I meant was, is the css minimised during the build process?

@RedYetiDev RedYetiDev closed this May 9, 2024
@RedYetiDev
Copy link
Member Author

I'll close this for now; and open smaller PRs if I think I can provide smaller changes. Thanks :-)

@ovflowd
Copy link
Member

ovflowd commented May 10, 2024

What I meant was, is the css minimised during the build process?

No

@ovflowd
Copy link
Member

ovflowd commented May 10, 2024

I'll close this for now; and open smaller PRs if I think I can provide smaller changes. Thanks :-)

Appreciate it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants