feat(core): allow partially resetting workspace #23381

AgentEnder · 2024-05-14T17:38:30Z

Current Behavior

nx reset takes no options, and will always shut down the daemon as well as remove all local cache entries. This isn't great, because it means that the next task gets a full cold start when the user may have just needed to restart the daemon to clear up the issue they are facing.
The projectGraphCacheDirectory defaults to the same directory as the regular cache directory, which can be a bit confusing when updating it doesn't cause it to go away.

Expected Behavior

nx reset allows users to pick what data is deleted
.nx/workspace-data is new project graph cache dir

Related Issue(s)

Fixes #

vercel · 2024-05-14T17:38:33Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	Jun 4, 2024 10:07pm

nx-cloud · 2024-05-14T17:40:51Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 571443e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

FrozenPandaz · 2024-05-14T22:18:59Z

packages/nx/src/command-line/reset/reset.ts

+        { name: 'workspaceData', message: 'Workspace Data' },
+      ],
+      footer: 'Press <space> to select, <return> to submit.',
+      indicator(state, choice) {


This is cool. Let's change the indicator in other places.

But when I reset, I don't want to be bothered by a prompt. I just want things reset.

We can keep the granularity flags but let's get rid of the prompt.

FrozenPandaz · 2024-06-03T16:23:02Z

docs/generated/cli/reset.md

+Clears all the cached Nx artifacts and metadata about the workspace and shuts down the Nx Daemon:
+
+```shell
+ nx reset --all


Remove the --all flag

FrozenPandaz · 2024-06-03T16:23:21Z

docs/generated/cli/reset.md

+Clears the Nx Cache directory. This will remove all local cache entries for tasks, but will not affect the remote cache:
+
+```shell
+ nx reset --cache


Can we make this --only-cache and --only-daemon

FrozenPandaz · 2024-06-04T21:15:04Z

docs/generated/cli/reset.md

@@ -1,11 +1,11 @@
 ---
 title: 'reset - CLI command'
-description: 'Clears all the cached Nx artifacts and metadata about the workspace and shuts down the Nx Daemon.'
+description: 'Clears cached Nx artifacts and metadata about the workspace and shuts down the Nx onlyDaemon.'


This was unintentionally replaced. Please change it back.

FrozenPandaz · 2024-06-04T21:15:39Z

docs/generated/cli/reset.md

+```shell
+ nx reset
+```
+
+Clears all the cached Nx artifacts and metadata about the workspace and shuts down the Nx Daemon:
+
+```shell
+ nx reset
+```


These are the same.

FrozenPandaz · 2024-06-04T21:17:49Z

docs/generated/cli/reset.md

+
+Type: `boolean`
+
+Clears the Nx onlyCache directory. This will remove all local onlyCache entries for tasks, but will not affect the remote onlyCache.


This wording is off.

FrozenPandaz · 2024-06-04T21:18:20Z

docs/generated/cli/reset.md

+
+Type: `boolean`
+
+Stops the Nx Daemon to reset its internal state.


This could be phrased better.. what about...

Stops the Nx Daemon, it will be restarted fresh when the next Nx command is run.

FrozenPandaz · 2024-06-04T21:27:48Z

packages/nx/migrations.json

+    "19-2-0-move-graph-cache-directory": {
+      "cli": "nx",
+      "version": "19.2.0-beta.2",
+      "description": "Updates the default graph cache directory to .nx/workspace-data",


Suggested change

"description": "Updates the default graph cache directory to .nx/workspace-data",

"description": "Updates the default workspace data directory to .nx/workspace-data",

FrozenPandaz · 2024-06-04T21:28:10Z

packages/nx/migrations.json

+      "cli": "nx",
+      "version": "19.2.0-beta.2",
+      "description": "Updates the default graph cache directory to .nx/workspace-data",
+      "implementation": "./src/migrations/update-19-2-0/move-graph-cache-directory"


Change the name.

github-actions · 2024-06-11T00:10:19Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

AgentEnder requested review from a team, FrozenPandaz, xiongemi and Coly010 as code owners May 14, 2024 17:38

AgentEnder requested a review from juristr May 14, 2024 17:38

vercel bot had a problem deploying to Preview May 14, 2024 17:39 Failure

AgentEnder force-pushed the feat/smol-reset branch from e8c03a6 to ff7787c Compare May 14, 2024 18:32

vercel bot had a problem deploying to Preview May 14, 2024 18:35 Failure

AgentEnder force-pushed the feat/smol-reset branch from ff7787c to 2453d62 Compare May 14, 2024 19:37

vercel bot had a problem deploying to Preview May 14, 2024 19:40 Failure

FrozenPandaz requested changes May 14, 2024

View reviewed changes

AgentEnder force-pushed the feat/smol-reset branch from 2453d62 to 5bcd325 Compare May 14, 2024 22:33

vercel bot deployed to Preview May 14, 2024 22:41 View deployment

AgentEnder force-pushed the feat/smol-reset branch from 5bcd325 to b538632 Compare May 15, 2024 15:10

vercel bot deployed to Preview May 15, 2024 15:19 View deployment

FrozenPandaz assigned AgentEnder May 16, 2024

AgentEnder force-pushed the feat/smol-reset branch 2 times, most recently from 9c45bce to 9b6e15b Compare May 29, 2024 21:20

vercel bot deployed to Preview May 29, 2024 21:28 View deployment

AgentEnder force-pushed the feat/smol-reset branch from 9b6e15b to e51379a Compare May 29, 2024 22:37

AgentEnder requested a review from a team as a code owner May 29, 2024 22:37

vercel bot deployed to Preview May 31, 2024 17:45 View deployment

AgentEnder force-pushed the feat/smol-reset branch from 5cb32a5 to fb77b60 Compare May 31, 2024 22:12

vercel bot deployed to Preview May 31, 2024 22:19 View deployment

AgentEnder force-pushed the feat/smol-reset branch from fb77b60 to e5ae718 Compare May 31, 2024 23:01

vercel bot deployed to Preview May 31, 2024 23:08 View deployment

FrozenPandaz requested changes Jun 3, 2024

View reviewed changes

AgentEnder force-pushed the feat/smol-reset branch from e5ae718 to fac07fd Compare June 4, 2024 19:43

vercel bot deployed to Preview June 4, 2024 19:51 View deployment

AgentEnder force-pushed the feat/smol-reset branch from fac07fd to 1e8c5d8 Compare June 4, 2024 20:34

AgentEnder requested a review from a team as a code owner June 4, 2024 20:34

AgentEnder requested a review from JamesHenry June 4, 2024 20:34

vercel bot deployed to Preview June 4, 2024 20:41 View deployment

AgentEnder force-pushed the feat/smol-reset branch from 1e8c5d8 to 237d3d6 Compare June 4, 2024 21:09

vercel bot deployed to Preview June 4, 2024 21:16 View deployment

AgentEnder force-pushed the feat/smol-reset branch from 237d3d6 to 1f467d3 Compare June 4, 2024 21:21

FrozenPandaz requested changes Jun 4, 2024

View reviewed changes

AgentEnder force-pushed the feat/smol-reset branch 2 times, most recently from 7d3f70c to e51fbe2 Compare June 4, 2024 21:30

vercel bot deployed to Preview June 4, 2024 21:45 View deployment

AgentEnder force-pushed the feat/smol-reset branch from e51fbe2 to 6012bab Compare June 4, 2024 21:46

vercel bot deployed to Preview June 4, 2024 21:53 View deployment

FrozenPandaz approved these changes Jun 4, 2024

View reviewed changes

feat(core): allow partially resetting workspace

571443e

AgentEnder force-pushed the feat/smol-reset branch from 6012bab to 571443e Compare June 4, 2024 22:01

vercel bot deployed to Preview June 4, 2024 22:07 View deployment

AgentEnder merged commit 5e39cb0 into master Jun 4, 2024
6 checks passed

AgentEnder deleted the feat/smol-reset branch June 4, 2024 22:55

Fabb111 mentioned this pull request Jun 8, 2024

19.2.0 update broke many generators (including @nx/next) #26470

Open

4 tasks

github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): allow partially resetting workspace #23381

feat(core): allow partially resetting workspace #23381

AgentEnder commented May 14, 2024 •

edited

vercel bot commented May 14, 2024 •

edited

nx-cloud bot commented May 14, 2024 •

edited

FrozenPandaz May 14, 2024

FrozenPandaz Jun 3, 2024

FrozenPandaz Jun 3, 2024

FrozenPandaz Jun 4, 2024

FrozenPandaz Jun 4, 2024

FrozenPandaz Jun 4, 2024

FrozenPandaz Jun 4, 2024

FrozenPandaz Jun 4, 2024

FrozenPandaz Jun 4, 2024

github-actions bot commented Jun 11, 2024


		Type: `boolean`

		Clears the Nx onlyCache directory. This will remove all local onlyCache entries for tasks, but will not affect the remote onlyCache.


		Type: `boolean`

		Stops the Nx Daemon to reset its internal state.

	"description": "Updates the default graph cache directory to .nx/workspace-data",
	"description": "Updates the default workspace data directory to .nx/workspace-data",

feat(core): allow partially resetting workspace #23381

feat(core): allow partially resetting workspace #23381

Conversation

AgentEnder commented May 14, 2024 • edited

Current Behavior

Expected Behavior

Related Issue(s)

vercel bot commented May 14, 2024 • edited

nx-cloud bot commented May 14, 2024 • edited

☁️ Nx Cloud Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jun 11, 2024

AgentEnder commented May 14, 2024 •

edited

vercel bot commented May 14, 2024 •

edited

nx-cloud bot commented May 14, 2024 •

edited