docs(core): elaborate output-style option #23521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 302e1aa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
elevenpassin
force-pushed
the
docs/elaborate-output-style-option
branch
from
1fdba4a
to
7dd20bd
Compare
|
@isaacplmann I also found an undocumented option here: found it here: https://github.com/nrwl/nx/blob/master/packages/nx/src/tasks-runner/run-command.ts#L251-L252 |
|
CI isn't passing because you need to run I'm not sure why |
elevenpassin
force-pushed
the
docs/elaborate-output-style-option
branch
from
e3d1549
to
891e4e1
Compare
|
I'm not certain either - I'd leave it undocumented for now :) |
AgentEnder
approved these changes
May 27, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
May 28, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> `output-style` option's potential values are not explained. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> add description to `output-style` option's potential values ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #20159  (cherry picked from commit e32b819)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
output-styleoption's potential values are not explained.Expected Behavior
add description to
output-styleoption's potential valuesRelated Issue(s)
Fixes #20159