Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-only test #1459

Closed
wants to merge 3 commits into from
Closed

grpc-only test #1459

wants to merge 3 commits into from

Conversation

tarekziade
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@tarekziade tarekziade requested a review from a team as a code owner October 16, 2023 13:16
@tarekziade tarekziade marked this pull request as draft October 16, 2023 13:16
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 918 files.

Valid Invalid Ignored Fixed
778 1 139 0
Click to see the invalid file list
  • nucliadb_node/nucliadb_node/tests/bench/test_search.py

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (90fa35a) 85.34% compared to head (31f1bd0) 85.34%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1459   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files         449      449           
  Lines       24960    24967    +7     
=======================================
+ Hits        21301    21308    +7     
  Misses       3659     3659           
Flag Coverage Δ
ingest 74.65% <ø> (ø)
nucliadb 68.64% <ø> (+0.01%) ⬆️
reader 76.73% <ø> (ø)
sdk 43.04% <ø> (ø)
search 82.29% <ø> (-0.20%) ⬇️
standalone 83.15% <ø> (ø)
train 60.33% <ø> (ø)
utils 85.15% <ø> (ø)
writer 84.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tarekziade and others added 2 commits October 16, 2023 16:17
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@lferran lferran closed this Jun 6, 2024
@javitonino javitonino deleted the tarek/grpcbench branch June 6, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants