Sc 9354/idp regional merge nucliadb predict and processing #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 966 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 860 | 8 | 98 | 0 |
Click to see the invalid file list
- nucliadb_utils/nucliadb_utils/nuclia_usage/init.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/init.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/kb_usage_pb2.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/kb_usage_pb2.pyi
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/kb_usage_pb2_grpc.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/kb_usage_pb2_grpc.pyi
- nucliadb_utils/nucliadb_utils/nuclia_usage/utils/init.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/utils/kb_usage_report.py
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 033555b | Previous: 3f27502 | Ratio |
|---|---|---|---|
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error |
13029.001128721698 iter/sec (stddev: 4.168134176542238e-7) |
12969.375444792455 iter/sec (stddev: 1.9097610071932152e-7) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
sunbit
reviewed
May 15, 2024
There was a problem hiding this comment.
license-eye has totally checked 972 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 866 | 8 | 98 | 0 |
Click to see the invalid file list
- nucliadb_utils/nucliadb_utils/nuclia_usage/init.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/init.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/kb_usage_pb2.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/kb_usage_pb2.pyi
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/kb_usage_pb2_grpc.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/kb_usage_pb2_grpc.pyi
- nucliadb_utils/nucliadb_utils/nuclia_usage/utils/init.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/utils/kb_usage_report.py
There was a problem hiding this comment.
license-eye has totally checked 972 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 866 | 8 | 98 | 0 |
Click to see the invalid file list
- nucliadb_utils/nucliadb_utils/nuclia_usage/init.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/init.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/kb_usage_pb2.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/kb_usage_pb2.pyi
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/kb_usage_pb2_grpc.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/kb_usage_pb2_grpc.pyi
- nucliadb_utils/nucliadb_utils/nuclia_usage/utils/init.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/utils/kb_usage_report.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2145 +/- ##
==========================================
- Coverage 76.22% 75.01% -1.22%
==========================================
Files 90 80 -10
Lines 6251 5868 -383
==========================================
- Hits 4765 4402 -363
+ Misses 1486 1466 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
license-eye has totally checked 972 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 866 | 8 | 98 | 0 |
Click to see the invalid file list
- nucliadb_utils/nucliadb_utils/nuclia_usage/init.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/init.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/kb_usage_pb2.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/kb_usage_pb2.pyi
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/kb_usage_pb2_grpc.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/protos/kb_usage_pb2_grpc.pyi
- nucliadb_utils/nucliadb_utils/nuclia_usage/utils/init.py
- nucliadb_utils/nucliadb_utils/nuclia_usage/utils/kb_usage_report.py
sunbit
approved these changes
May 21, 2024
lferran
reviewed
May 21, 2024
nucliadb_utils/nucliadb_utils/nuclia_usage/utils/kb_usage_report.py
Outdated
Show resolved
Hide resolved
lferran
reviewed
May 21, 2024
lferran
reviewed
May 21, 2024
nucliadb_utils/nucliadb_utils/nuclia_usage/utils/kb_usage_report.py
Outdated
Show resolved
Hide resolved
lferran
reviewed
May 21, 2024
lferran
reviewed
May 21, 2024
lferran
reviewed
May 22, 2024
lferran
reviewed
May 22, 2024
lferran
reviewed
May 22, 2024
lferran
approved these changes
May 23, 2024
drf7
deleted the
sc-9354/idp-regional-merge-nucliadb-predict-and-processing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.