Add vectorsets support to bindings #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lferran
reviewed
May 17, 2024
Comment on lines
-640
to
-657
| #[tracing::instrument(skip_all)] | ||
| pub fn paragraph_count(&self) -> NodeResult<usize> { | ||
| read_rw_lock(&self.paragraph_reader).count() | ||
| } | ||
|
|
||
| #[tracing::instrument(skip_all)] | ||
| pub fn vector_count(&self) -> NodeResult<usize> { | ||
| read_rw_lock(&self.vector_readers) | ||
| .get(DEFAULT_VECTORS_INDEX_NAME) | ||
| .expect("Default vectors index should never be deleted (yet)") | ||
| .count() | ||
| } | ||
|
|
||
| #[tracing::instrument(skip_all)] | ||
| pub fn text_count(&self) -> NodeResult<usize> { | ||
| read_rw_lock(&self.text_reader).count() | ||
| } | ||
|
|
There was a problem hiding this comment.
can this be removed safely?
There was a problem hiding this comment.
Yes, no one was calling this methods
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: bf028c5 | Previous: 7a0c806 | Ratio |
|---|---|---|---|
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error |
12975.880162181527 iter/sec (stddev: 3.414487744898704e-7) |
13028.091115305282 iter/sec (stddev: 9.732238981112996e-8) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2162 +/- ##
==========================================
- Coverage 76.22% 76.20% -0.03%
==========================================
Files 90 90
Lines 6251 6240 -11
==========================================
- Hits 4765 4755 -10
+ Misses 1486 1485 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lferran
approved these changes
May 20, 2024
jotare
deleted the
joanantoniriera4168/sc-10207/add-vectorsets-support-to-bindings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.