Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top-level crate documentation/READMEs #12907

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

sholderbach
Copy link
Member

Description

Add README.md files to each crate in our workspace (-plugins) and also include it in the lib.rs documentation for <docs.rs> (if there is no existing lib.rs crate documentation)

In all new README I added the defensive comment that the crates are not considered stable for public consumption. If necessary we can adjust this if we deem a crate useful for plugin authors.

Include disclaimer that they are internal until proven otherwise
Fix incompatible code-fences.
As `rustdoc` assumes `rust` others need to declare a language or use
`text`

TODO some crates have their own crate level docs independent of a README
@sholderbach sholderbach added the documentation issues relating to documentation label May 20, 2024
@sholderbach
Copy link
Member Author

Something in nu-json (which is a fork of serde-hjson originally) is up that it won't parse the example copied over from the original crate in the README. As I moved the README into lib.rs this now gets doctested and fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues relating to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant